Project

General

Profile

Bug #1011

Chinese GB18030 transcoding is breaking build at r21509

Added by luislavena (Luis Lavena) over 11 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
ruby -v:
Backport:
[ruby-core:21345]

Description

=begin
While building from sources, revision r21509 introduced the following problem:

generating enc/trans/escape.c ...
converter for amp_escape
converter for xml_text_escape
converter for xml_attr_content_escape
converter for escape_xml_attr_quote
done.
ruby -I/home/luislavena/.rake-compiler/builds/ruby-1.9.1-trunk -rfake "/home/luislavena/.rake-compiler/sources/ruby-1.9.1-trunk/tool/transcode-tblgen.rb" -vo "enc/trans/gb18030.c" "/home/luislavena/.rake-compiler/sources/ruby-1.9.1-trunk/enc/trans/gb18030.trans"
generating enc/trans/gb18030.c ...
/home/luislavena/.rake-compiler/sources/ruby-1.9.1-trunk/enc/trans/gb18030.trans:8: compile error (SyntaxError)
/home/luislavena/.rake-compiler/sources/ruby-1.9.1-trunk/enc/trans/gb18030.trans:7: syntax error, unexpected ',', expecting ']'
/home/luislavena/.rake-compiler/sources/ruby-1.9.1-trunk/enc/trans/gb18030.trans:8: syntax error, unexpected ',', expecting $end from /home/luislavena/.rake-compiler/sources/ruby-1.9.1-trunk/tool/transcode-tblgen.rb:821
make[1]: *** [enc/trans/gb18030.c] Error 1
make[1]: Leaving directory `/home/luislavena/.rake-compiler/builds/ruby-1.9.1-trunk'
make: *** [srcs-enc] Error 2

Going back to r21508 make the problem go away.

The log of the commit is the following:


r21509 | duerst | 2009-01-14 09:12:30 -0200 (Wed, 14 Jan 2009) | 11 lines

  • enc/trans/gb18030.trans, gb18030-tbl.rb:
    new Chinese GB18030 transcoding (from Yoshihiro Kambayashi)

  • test/ruby/test_transcode.rb: added tests for the above
    (from Yoshihiro Kambayashi)

  • transcode_data.h, transcode.c, tool/transcode_tblgen.rb:
    added support for GB18030-specific 4-byte sequences
    (with Yoshihiro Kambayashi)
    =end

#1

Updated by nobu (Nobuyoshi Nakada) over 11 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

=begin
Applied in changeset r21512.
=end

#2

Updated by duerst (Martin Dürst) over 11 years ago

=begin
Hello Nobu, Luis,

Many thanks for detecting and fixing this bug.
(I removed the ID from the subject because I don't think
this message should show up in the bug tracker.)

BTW, when compiling enc/trans/gb18030.c, on cygwin
we get warning messages of the following form:

/cygdrive/c/......./Temp/cc1gVWpf.s: Assembler messages:
/cygdrive/c/......./Temp/cc1gVWpf.s:149974: Warning: .stabs: description field '174af' too big, try a diferent debug format

There's roughly 60 such messages, with slightly different line numbers
and with various (but sometimes the same) field ids.

It's clear to me what these messages mean in general.
It's clear that gb18030.c contains some huge tables,
and that it's stressing the debug format.

However, I have no idea whether this is a cygwin problem
or a more general problem, and I have no idea what I should
do about it, if anything can be done about it.

Please do note that we are working on reducing the table
size further, but probably only by 25-30%. If you think
that will help, we'll make sure we can complete this quickly.

Any help appreciated. Regards, Martin.

At 00:06 09/01/15, Nobuyoshi Nakada wrote:

Issue #1011 has been updated by Nobuyoshi Nakada.

Status changed from Open to Closed
% Done changed from 0 to 100

Applied in changeset r21512.

http://redmine.ruby-lang.org/issues/show/1011


http://redmine.ruby-lang.org

#-#-# Martin J. Du"rst, Assoc. Professor, Aoyama Gakuin University
#-#-# http://www.sw.it.aoyama.ac.jp mailto:duerst@it.aoyama.ac.jp

=end

Also available in: Atom PDF