Feature #10057: [PATCH] Add tests for Matrix class.

• Status: Closed
• Assignee: -
• Target version: -

[gogotanaka (Kazuki Tanaka)]

I send 7 patches.

In one of patches (reorder_Matrix#real_and_Matrix_imaginary.patch), I just reorder methods.

I think Matrix#real should be upon Matrix#imaginary(From what I see complex.c)

In the others(6 patches), I add tests for Matrix class.

[hsbt (Hiroshi SHIBATA)]

Please split new feature and tests into another issue.

[gogotanaka (Kazuki Tanaka)]

@ Hiroshi SHIBATA さん

I split patch "reorder_Matrix#real_and_Matrix_imaginary.patch" to https://bugs.ruby-lang.org/issues/10058

How can I delete patch from feature ?

承知致しました.

7つのPATCHの内、"reorder_Matrix#real_and_Matrix_imaginary.patch"

はこちら https://bugs.ruby-lang.org/issues/10058 に切り出させて頂きました.

一度featureに添付したPATCHは削除出来ないのでしょうか.

[hsbt (Hiroshi SHIBATA)]

• File deleted (reorder_Matrix#real_and_Matrix_imaginary.patch)

[hsbt (Hiroshi SHIBATA)]

• % Done changed from 0 to 100
• Status changed from Open to Closed

Applied in changeset r46861.

---

• test/matrix/test_matrix.rb: Add tests for Matrix class.
  [Feature #10057][ruby-core:63809]

[marcandre (Marc-Andre Lafortune)]

Gogo Tanaka san,

Thanks for these additional tests.

Please note that the vast majority of tests of the Matrix library are in RubySpec: https://github.com/rubysl/rubysl-matrix

I hope you'll find them extensive, having for instance many more tests than found in this patch imaginary. If you'd like to port them this would be great.

[gogotanaka (Kazuki Tanaka)]

@ Hiroshi SHIBATA さん

ファイルの削除や進捗、ステータスのハンドリングありがとうございます.

Thank you for your some supports.

@ Mr. Marc-Andre Lafortune

I don't know that ... ! it's great! Thank you for your kindness!!!