Project

General

Profile

Actions

Bug #10031

closed

Net::IMAP idle can still block a thread forever.

Added by chilon (James Pike) over 9 years ago. Updated over 8 years ago.

Status:
Closed
Target version:
-
ruby -v:
ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-linux]
[ruby-core:63693]

Description

When calling Net::IMAP idle often errors will go unnoticed forever, simply leaving the Thread that called "idle" blocking forever.

For example try bringing your internet connection down whilst a thread is calling the idle method, the calling thread will now be blocked forever.

I've encountered this issue also without losing my internet connection, sometimes the remote server will disconnect the client and the client will never notice leading to the same issue.

Updated by normalperson (Eric Wong) over 9 years ago

Setting SO_KEEPALIVE on the socket will help, but that still takes at
least 2 hours to detect on a stock Linux system. Do you want to set a
shorter keepalive, or is ~2 hours OK?

You can change the interval using OS-specific knobs (e.g. sysctl).

Totally untested one line patch here:

--- a/lib/net/imap.rb
+++ b/lib/net/imap.rb
@@ -1053,6 +1053,7 @@ module Net
       @tagno = 0
       @parser = ResponseParser.new
       @sock = TCPSocket.open(@host, @port)
+      @sock.setsockopt(:SOL_SOCKET, :SO_KEEPALIVE, 1)
       begin
	 if options[:ssl]
	   start_tls_session(options[:ssl])

Updated by shugo (Shugo Maeda) over 9 years ago

  • Status changed from Open to Assigned
  • Assignee set to shugo (Shugo Maeda)
Actions #3

Updated by shugo (Shugo Maeda) over 8 years ago

  • Status changed from Assigned to Closed

Applied in changeset r52216.


Updated by shugo (Shugo Maeda) over 8 years ago

I've added a new argument timeout for Net::IMAP#idle to solve this problem.

For example, the following code checks the connection for each 60 seconds.

loop do
  imap.idle(60) do |res|
    ...
  end
end
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0