General

Profile

jonathanhefner (Jonathan Hefner)

Issues

open closed Total
Assigned issues 0 0 0
Reported issues 1 3 4

Activity

12/01/2022

05:19 PM Ruby master Bug #19079: Modules included in a DelegateClass cannot override delegate methods
This issue occurred for a private module in Rails: https://github.com/rails/rails/pull/46189#discussion_r991440668.
...
jonathanhefner (Jonathan Hefner)

10/23/2022

03:02 AM Ruby master Bug #19079: Modules included in a DelegateClass cannot override delegate methods
I have submitted a PR with the proposed solution: https://github.com/ruby/delegate/pull/14. jonathanhefner (Jonathan Hefner)
03:01 AM Ruby master Bug #19079 (Rejected): Modules included in a DelegateClass cannot override delegate methods
Because `DelegateClass` defines delegate methods on the class itself, those delegate methods come first in the method... jonathanhefner (Jonathan Hefner)

10/14/2022

03:08 PM Ruby master Revision 60610031 (git): [ruby/delegate] Fix DelegateClass block "method redefined" warning
This commit prevents "method redefined" warnings when overriding methods
within a `DelegateClass` block, such as in t...
jonathanhefner (Jonathan Hefner)

10/13/2022

04:36 PM Ruby master Bug #19047: DelegateClass displays "method redefined" warning when overriding methods
> Thank you, now the issue is that `delegate` doesn't have a maintainer: https://github.com/ruby/ruby/commit/1159dbf3... jonathanhefner (Jonathan Hefner)

10/11/2022

09:41 PM Ruby master Bug #19047: DelegateClass displays "method redefined" warning when overriding methods
Submitted `alias_method` patch as https://github.com/ruby/delegate/pull/13. jonathanhefner (Jonathan Hefner)
08:50 PM Ruby master Bug #19047: DelegateClass displays "method redefined" warning when overriding methods
> The main reason to prefer `alias_method` is that it's the least amount of changes, so least likely to break anythin... jonathanhefner (Jonathan Hefner)
06:09 PM Ruby master Bug #19047: DelegateClass displays "method redefined" warning when overriding methods
Indeed, `alias_method` is another possibility! And also [Jean's suggestion](https://github.com/rails/rails/pull/4618... jonathanhefner (Jonathan Hefner)

10/10/2022

07:30 PM Ruby master Bug #19047 (Closed): DelegateClass displays "method redefined" warning when overriding methods
Perhaps this is not a bug, but it does seem unexpected.
When creating a `DelegateClass` class without an interveni...
jonathanhefner (Jonathan Hefner)

12/07/2020

06:41 PM Ruby master Misc #17346: DevelopersMeeting20201210Japan
* [Bug #15661] Disallow concurrent Dir.chdir with block (jonathanhefner)
* This change is causing some issues in R...
jonathanhefner (Jonathan Hefner)

Also available in: Atom