Thanks @hsbt - yeah my current job has no Ruby at all and I haven’t committed in quite a while, so giving up access seems like the responsible thing to do from a security perspective. I hope I get a bit more time in the future for Rub...kjtsanaktsidis (KJ Tsanaktsidis)
Heya - sorry I've been away from Ruby for a little while, but this caught my eye and I wanted to bring your attention to a similar bug I opened about rb_current_ec with M:N threading last year: https://bugs.ruby-lang.org/issues/20243 ...kjtsanaktsidis (KJ Tsanaktsidis)
> If rb_nogvl is called in the fiber scheduler, it can introduce latency, as releasing the GVL will prevent the event loop from progressing while nogvl function is executing I definitely understand the problem here. But… dealing with ...kjtsanaktsidis (KJ Tsanaktsidis)
Applied in changeset commit:git|dcf3add96bd6e117435c568e78be59bb7ecad701. ---------- Delete reserve_stack code This code was working around a bug in the Linux kernel. It was previously possible for the kernel to place heap pages in a r...kjtsanaktsidis (KJ Tsanaktsidis)
This code was working around a bug in the Linux kernel. It was previously possible for the kernel to place heap pages in a region where the stack was allowed to grow into, and then therefore run out of usable stack memory before RLIMIT_S...kjtsanaktsidis (KJ Tsanaktsidis)
In Linux, the main thread generally only gets a small stack mapped in initially. As the application attempts to use more stack memory, the kernel will map in more stack pages. In https://github.com/ruby/ruby/pull/822, we added some lo...kjtsanaktsidis (KJ Tsanaktsidis)
Sorry it took me so long to get back to you @akr . I've added a short comment about this - if you're OK with it I will commit it. Thanks!kjtsanaktsidis (KJ Tsanaktsidis)
If one thread is reading and another closes that socket, the close blocks waiting for the read to abort cleanly. This ensures that Ruby is totally done with the file descriptor _BEFORE_ we tell the OS to close and potentially re-use it. ...kjtsanaktsidis (KJ Tsanaktsidis)