Project

General

Profile

Actions

Bug #8990

closed

please disable *context on hurd

Added by gg0 (Gabriele Giacone) over 10 years ago. Updated over 10 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
ruby 2.0.0p299 (2013-08-29) [i386-gnu]
[ruby-core:57685]

Description

This bug can be reproduced in Ruby 1.8 as well.

Attached patch disables *context use on hurd.
Hurd implementation is not working yet and it's hard estimating whenever it will be.

Thanks.


Files

patch01 (616 Bytes) patch01 gg0 (Gabriele Giacone), 10/06/2013 06:49 AM
Actions #1

Updated by kosaki (Motohiro KOSAKI) over 10 years ago

  1. Every workaroud patch should have a comment why it is needed any which version has a problem. Even though prior work don't.
  2. defined(GNU) is unclear and confusable because a lot of people aren't familiar Hurd. So, it should be commented it's for GNU/Hurd.
  3. Now, we have 5th exception (MS-Windows, NetBSD, Solaris, IA64, Hurd). So, it's a good time to move the check to configure.in.

Updated by naruse (Yui NARUSE) over 10 years ago

  • Status changed from Open to Feedback

Updated by gg0 (Gabriele Giacone) over 10 years ago

kosaki (Motohiro KOSAKI) wrote:

  1. Every workaroud patch should have a comment why it is needed any which version has a problem. Even though prior work don't.

Comment might be: "GNU/Hurd doesn't fully support {get,set,make,swap}context functions. Disabling their usage till support is implemented. More info at http://darnassus.sceen.net/~hurd-web/open_issues/glibc/#getcontext"
Feel free to rephrase as you prefer.

  1. defined(GNU) is unclear and confusable because a lot of people aren't familiar Hurd. So, it should be commented it's for GNU/Hurd.

It's fine what you did in r43077.

Actions #4

Updated by kosaki (Motohiro KOSAKI) over 10 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r43193.
Gabriele, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


Updated by kosaki (Motohiro KOSAKI) over 10 years ago

Committed at r43193. Thank you!

Updated by nagachika (Tomoyuki Chikanaga) over 10 years ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN to 1.9.3: UNKNOWN, 2.0.0: DONE

backported to ruby_2_0_0 at r43225.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0