Bug #8522: r41264 causes "implicit conversion loses integer precision" on clang

• Status: Closed
• Assignee: akr (Akira Tanaka)
• Target version: 2.1.0
• ruby -v: -
• Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN

[drbrain (Eric Hodel)]

=begin
compiling ../trunk/bignum.c
../trunk/bignum.c:1128:46: error: implicit conversion loses integer precision:
'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]
*nlp_bits_ret = num_bdigits * BITSPERDIG - num_bits;
~ ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
1 error generated.
make: *** [bignum.o] Error 1

=end

[drbrain (Eric Hodel)]

• File bignum.c.bug8522.patch bignum.c.bug8522.patch added

This patch changes int nlp_bits to size_t nlp_bits, but I don't know enough about bignum.c to know if this is appropriate.

[akr (Akira Tanaka)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r41267.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• bignum.c (integer_unpack_num_bdigits_small): Fix a comple error on
  clang -Werror,-Wshorten-64-to-32
  Reported by Eric Hodel. [ruby-core:55467] [Bug #8522]