test_system_redirect_win(TestSystem) failure on Windows 8
I found the following test failure on Windows 8.
expected but was
I think the test_system_redirect_win is a wrong test case.
the ping command is not the point of [ruby-talk:258939].
And the ping result may differ depending on the machine.
Updated by nobu (Nobuyoshi Nakada) over 7 years ago
- Status changed from Feedback to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r38956.
Heesob, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
test_system.rb: fix test
- test/ruby/test_system.rb (TestSystem#test_system_redirect_win): fix meaningless test. [Bug #7482]
Updated by phasis68 (Heesob Park) over 7 years ago
As you can see in http://ci.rubyinstaller.org/job/ruby-trunk-x64-test-all/607/console,
This issues is not solved with changeset r38956.
"'\"C:\Windows/system32/find.exe BFI3CHL671\"' is not recognized as an internal or external command,\n"
"operable program or batch file.\n"
system("\"%WINDIR%/system32/find.exe BFI3CHL671\" input.txt > out.txt 2>err.txt").
expected but was
This failure is also occurred on Windows 8.
I'm not sure why you think the third case should be true.
Here is patch:
diff --git a/test_system.rb b/test_system.rb.new
index b877538..db19a3c 100644
@@ -141,7 +141,7 @@ class TestSystem < Test::Unit::TestCase
cmd = "\"%WINDIR%/system32/find.exe\" \"BFI3CHL671\" input.txt > out.txt 2>err.txt"
assert_equal(true, system(cmd), message)
cmd = "\"%WINDIR%/system32/find.exe BFI3CHL671\" input.txt > out.txt 2>err.txt"
- assert_equal(true, system(cmd), message)
- assert_equal(false, system(cmd), message) end end end