Bug #7467: lib/mkmf.rb merge_lib fails on larger sets of libraries

• Status: Closed
• Assignee: nobu (Nobuyoshi Nakada)
• Target version: 2.0.0
• ruby -v: ruby 1.9.3p286 (2012-10-12 revision 37165) [x86_64-darwin12.2.0]

[mpapis (Michal Papis)]

running:

merge_libs(["-lncurses", "-ltinfo", "-lssl", "-lcrypto", "-lz", "-lreadline", "-ltermcap", "-lyaml"],["-lcrypto", "-lssl", "-lcrypto", "-lz"],[])

fails with an exception

I have tried a bit and it works fine with a lot simplified version of this code:

def merge_libs(*libs)
libs.flatten.uniq
end

Also can this be backported to Ruby 1.9.3?

[mpapis (Michal Papis)]

here is a link to a working patch: https://github.com/tokaido/tokaido-build/blob/master/patches/darwin/1.9.3-p327/fix_merge_libs.patch

[usa (Usaku NAKAMURA)]

• Category set to lib
• Status changed from Open to Assigned
• Assignee set to nobu (Nobuyoshi Nakada)
• Target version set to 2.0.0

[nobu (Nobuyoshi Nakada)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r39128.
Michal, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

mkmf.rb: fix merge_libs

• lib/mkmf.rb (MakeMakefile#merge_libs): insert following reversal
  ordered elements just after the duplicated element, not overwriting
  successive elements. [ruby-core:50314] [Bug #7467]

[mpapis (Michal Papis)]

just curious what the new code does more over the simple libs.flatten.uniq?