Project

General

Profile

Feature #7067

IO#reopen should accept File::Constants

Added by Glass_saga (Masaki Matsushita) almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Target version:
[ruby-core:47694]

Description

Hello,

I think IO#reopen should accept File::Constants because it is difficult to get mode string from File::Constants.
I have attached a patch.


Files

patch.diff (1.81 KB) patch.diff Glass_saga (Masaki Matsushita), 09/25/2012 11:58 PM
patch.diff (1.64 KB) patch.diff Glass_saga (Masaki Matsushita), 09/27/2012 11:34 PM

Updated by nobu (Nobuyoshi Nakada) almost 8 years ago

  • Assignee set to Glass_saga (Masaki Matsushita)

Seems fine to me.

Updated by Glass_saga (Masaki Matsushita) almost 8 years ago

Sorry, I made a mistake.
The patch is untabified code.
I have attached tabified one.

#3

Updated by nobu (Nobuyoshi Nakada) almost 8 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r37041.
Masaki, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


io.c: IO#reopen int mode

  • io.c (rb_io_reopen): accept File::Constants as well as mode string. based on the patch by Glass_saga (Masaki Matsushita) in [ruby-core:47694]. [Feature #7067]

Also available in: Atom PDF