Project

General

Profile

Actions
Copy link

Bug #6909

closed

Documentation for XMLRPC

Bug #6909: Documentation for XMLRPC

Added by zzak (zzak _) about 13 years ago. Updated about 13 years ago.

Status:
Closed
Assignee:
zzak (zzak _)
Target version:
2.0.0
ruby -v:
2.0.0
Backport:
[ruby-core:47286]

Description

Here's a patch for XMLRPC's documentation, brings it close to 50% coverage.

Files

Download all files
0001-Documentation-for-XMLRPC.patch (122 KB) 0001-Documentation-for-XMLRPC.patch zzak (zzak _), 08/23/2012 09:22 AM
0002-Documentation-for-XMLRPC.patch (92.7 KB) 0002-Documentation-for-XMLRPC.patch zzak (zzak _), 08/25/2012 10:10 PM

Updated by drbrain (Eric Hodel) about 13 years ago Actions
Copy link
 #1 [ruby-core:47306]

Please separate whitespace and content changes. It is too hard to tell if an accidental change to the code has happened.

I noticed combined changes in:

xmlrpc/base64.rb
xmlrpc/client.rb
xmlrpc/datetime.rb
xmlrpc/server.rb
xmlrpc/utils.rb

Other than the combined changes, I think this patch is OK.

Updated by zzak (zzak _) about 13 years ago Actions
Copy link
 #2 [ruby-core:47307]

Thanks for your feedback Eric, attached as 0002-* is a new patch sans all the whitespace changes.

Updated by drbrain (Eric Hodel) about 13 years ago Actions
Copy link
 #3 [ruby-core:47376]

This looks good, please commit it.

Updated by drbrain (Eric Hodel) about 13 years ago Actions
Copy link
 #4 [ruby-core:47435]

  • Assignee changed from drbrain (Eric Hodel) to zzak (zzak _)

Updated by zzak (zzak _) about 13 years ago Actions
Copy link
 #5

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r36958.
Zachary, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

  • lib/xmlrpc.rb: Documentation for XMLRPC
  • lib/xmlrpc/datetime.rb: ditto.
  • lib/xmlrpc/parser.rb: ditto.
  • lib/xmlrpc/client.rb: ditto.
  • lib/xmlrpc/utils.rb: ditto.
  • lib/xmlrpc/README.rdoc: ditto.
  • lib/xmlrpc/create.rb: ditto.
  • lib/xmlrpc/base64.rb: ditto.
  • lib/xmlrpc/config.rb: ditto.
  • lib/xmlrpc/httpserver.rb: ditto.
  • lib/xmlrpc/server.rb: ditto.
  • lib/xmlrpc/marshal.rb: ditto.
  • lib/xmlrpc/README.txt: ditto.
    [Bug #6909] [ruby-core:47286]
Actions
Copy link

Also available in: PDF Atom