Project

General

Profile

Actions

Bug #6813

closed

TestRubyOptions#test_encoding failure on Windows

Added by h.shirosaki (Hiroshi Shirosaki) over 11 years ago. Updated over 11 years ago.

Status:
Closed
Target version:
ruby -v:
ruby 2.0.0dev (2012-07-30 trunk 36577) [x64-mswin64_100]
Backport:
[ruby-core:46872]

Description

TestRubyOptions#test_encoding fails. This failure depends on cmd code page.
With chcp 932 the test passes, but with chcp 65001, 1252 and so on the test fails.

[ 9/38] TestRubyOptions#test_encoding = 0.04 s

  1. Failure:
    test_encoding(TestRubyOptions) [C:/Users/hiroshi/work/ruby/test/ruby/test_rubyop
    tions.rb:202]:
    <[]> expected but was
    <[""\xE3\x81\x82""]>.

This test depends on STDIN encoding which is determined system locale.
And LANG=C is set when invoking ruby.

https://github.com/ruby/ruby/blob/trunk/test/ruby/envutil.rb#L48

But LANG doesn't affect locale with trunk ruby on Windows by the following commit.
https://github.com/ruby/ruby/commit/5a2758ed

So test results would differ according to cmd code page.

I've attached a patch to work with not 932 code page.


Files

0001-Fix-test_encoding-failure-on-Windows.patch (1.66 KB) 0001-Fix-test_encoding-failure-on-Windows.patch h.shirosaki (Hiroshi Shirosaki), 07/30/2012 11:36 PM
Actions

Also available in: Atom PDF

Like0
Like0Like0