Project

General

Profile

Actions

Bug #6700

closed

[PATCH] Fix some 4xx status classes to inherit correctly from Net::HTTPClientError

Added by madeofcode (Mark Dodwell) over 11 years ago. Updated over 11 years ago.

Status:
Closed
Target version:
ruby -v:
ruby 2.0.0dev (2012-07-05 trunk 36311) [x86_64-darwin11.4.2]
Backport:
[ruby-core:46189]

Description

These recently added 4xx status classes were inheriting from Net::HTTPSuccess, which seems incorrect.

I believe they should inherit from Net::HTTPClientError, as with all the other 4xx cases.

Note that this change subtly alters/fixes the behavior of these classes since they will now inherit the EXCEPTION_TYPE = Net::HTTPServerException from Net::HTTPClientError which they would not have had previously. I expect that's disable, but just wanted to flag that.


Files

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0