Project

General

Profile

Actions

Bug #6393

closed

rdoc does not parse multibyte files

Added by nobu (Nobuyoshi Nakada) almost 12 years ago. Updated over 11 years ago.

Status:
Closed
Target version:
ruby -v:
r35518
Backport:
[ruby-core:44798]

Description

=begin
(({RDoc::Parser.binary?})) mistakenly returns (({true})) against the
file which contains correct multibyte content.
The method reads 1024bytes in binary mode, but it may end in the
middle of a character and have incomplete byte sequence.
=end


Files

0002-rdoc-non-binary-multibyte.patch (1.19 KB) 0002-rdoc-non-binary-multibyte.patch nobu (Nobuyoshi Nakada), 05/02/2012 03:47 PM

Updated by nobu (Nobuyoshi Nakada) almost 12 years ago

  • Status changed from Open to Assigned
Actions #2

Updated by nobu (Nobuyoshi Nakada) almost 12 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r35531.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


rdoc: non-binary multibyte

  • lib/rdoc/parser.rb (RDoc.binary?): binary read data may have
    incomplete multibyte sequence. [ruby-core:44798][Bug #6393]

Updated by nobu (Nobuyoshi Nakada) over 11 years ago

  • Status changed from Closed to Assigned
  • Priority changed from Normal to 5
  • % Done changed from 100 to 0

Updated by drbrain (Eric Hodel) over 11 years ago

  • Status changed from Assigned to Closed

Thank you for the patch, I have checked it and it is good.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0