Project

General

Profile

Bug #6255

RUBY_LIB_PREFIX in missing/alloca.c

Added by kimuraw (Wataru Kimura) over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
ruby 2.0.0dev (2012-04-04) [powerpc-darwin8.11.0]
Backport:
[ruby-dev:45492]

Description

木村といいます。

missing/alloca.cに

61 #ifdef RUBY_LIB_PREFIX
62 #define xmalloc ruby_xmalloc
63 #define xfree ruby_xfree
64 #endif

というコードがありますが、trunkではRUBY_LIB_PREFIXが
ruby/config.hからverconf.h (version.c)に移されていて、
これはmissing/alloca.cから参照されません。

このifdefは必ず偽になるのではないでしょうか。
だとしたらコードの意図が実現されていないのではないかと思うのです。

ppc Macでtrunk(r35238)をコンパイルしようとして #2735 と同じエラーが
でたのを調べていて気付きました。

Associated revisions

Revision 789f9c22
Added by nobu (Nobuyoshi Nakada) over 7 years ago

  • missing/alloca.c (xmalloc, xfree): use ruby version, not depending on RUBY_LIB_PREFIX. [ruby-dev:45492][Bug #6255]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35240 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 35240
Added by nobu (Nobuyoshi Nakada) over 7 years ago

  • missing/alloca.c (xmalloc, xfree): use ruby version, not depending on RUBY_LIB_PREFIX. [ruby-dev:45492][Bug #6255]

Revision 35240
Added by nobu (Nobuyoshi Nakada) over 7 years ago

  • missing/alloca.c (xmalloc, xfree): use ruby version, not depending on RUBY_LIB_PREFIX. [ruby-dev:45492][Bug #6255]

Revision 35240
Added by nobu (Nobuyoshi Nakada) over 7 years ago

  • missing/alloca.c (xmalloc, xfree): use ruby version, not depending on RUBY_LIB_PREFIX. [ruby-dev:45492][Bug #6255]

Revision 35240
Added by nobu (Nobuyoshi Nakada) over 7 years ago

  • missing/alloca.c (xmalloc, xfree): use ruby version, not depending on RUBY_LIB_PREFIX. [ruby-dev:45492][Bug #6255]

Revision 35240
Added by nobu (Nobuyoshi Nakada) over 7 years ago

  • missing/alloca.c (xmalloc, xfree): use ruby version, not depending on RUBY_LIB_PREFIX. [ruby-dev:45492][Bug #6255]

Revision 35240
Added by nobu (Nobuyoshi Nakada) over 7 years ago

  • missing/alloca.c (xmalloc, xfree): use ruby version, not depending on RUBY_LIB_PREFIX. [ruby-dev:45492][Bug #6255]

History

#1

Updated by nobu (Nobuyoshi Nakada) over 7 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r35240.
Wataru, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • missing/alloca.c (xmalloc, xfree): use ruby version, not depending on RUBY_LIB_PREFIX. [ruby-dev:45492][Bug #6255]

Also available in: Atom PDF