Project

General

Profile

Actions

Feature #6241

closed

Module#method_defined? with inherited flag

Added by nobu (Nobuyoshi Nakada) over 12 years ago. Updated about 12 years ago.

Status:
Rejected
Target version:
[ruby-dev:45483]

Description

=begin
Currently (({Module#method_defined?})) does not accept "(({inherited}))" flags as (({Module#instance_methods})) and others.
To tell if a method is defined at an exact class/module, we have to use bad idiom:

mod.instance_methods(false).include?(:foo)

So I propose to let (({method_defined?})) and etc accept the flag.
=end


Files

0001-inherited-flag.patch (8.69 KB) 0001-inherited-flag.patch nobu (Nobuyoshi Nakada), 04/01/2012 09:01 AM

Related issues 1 (0 open1 closed)

Related to Ruby master - Feature #5673: undef_method probably doesn't need to raise an errorFeedbackmatz (Yukihiro Matsumoto)Actions
Actions #1

Updated by nobu (Nobuyoshi Nakada) over 12 years ago

  • Tracker changed from Bug to Feature

Updated by trans (Thomas Sawyer) over 12 years ago

I think this is certainly a good idea. But I want to also point out that it's not always ideal either b/c #method_defined? reports false for private/protected methods. So in cases where the method in question might not have known visibility one would have to do:

if method_defined?(:foo) or private_method_defined?(:foo) or protected_method_defined?(:foo)

which sucks. Of course, this has always been an issue with #instance_methods too.

Perhaps now that named parameters are coming into their own, the interface should be modified to handle options?

method_defined?(:foo, all: true, inherited: false)

Updated by matz (Yukihiro Matsumoto) about 12 years ago

  • Status changed from Assigned to Rejected
  • Target version changed from 2.0.0 to 2.6

Tomas has a point. We cannot accept the original idea.
So I reject this proposal. Try again.

In general I am not a big fun of inherited flag, since most inheritance works rather as composition in Ruby.

Matz.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0