Project

General

Profile

Actions

Backport #5753

closed

[Ripper] on_magic_comment doesn't pass proper value

Added by nobu (Nobuyoshi Nakada) over 12 years ago. Updated about 11 years ago.

Status:
Closed
[ruby-dev:44984]

Description

=begin
$ ruby -v -rripper -e 'r = Ripper.new("# -- foo: bar --"); def r.on_magic_comment(*x);p x;end;r.parse'
["foo", false]

Should be ((%["foo", "bar"]%)).

Affects also 1.9.
=end

Actions #1

Updated by nobu (Nobuyoshi Nakada) over 12 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r34022.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


Actions #2

Updated by nobu (Nobuyoshi Nakada) over 12 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby master to Backport193
  • Category deleted (ext)
  • Target version deleted (2.0.0)

Updated by nobu (Nobuyoshi Nakada) about 11 years ago

  • Status changed from Closed to Assigned
  • Assignee changed from nobu (Nobuyoshi Nakada) to usa (Usaku NAKAMURA)
Actions #4

Updated by usa (Usaku NAKAMURA) about 11 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r40228.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 34022: [Backport #5753]

* parse.y (parser_magic_comment): should pass the proper value.
  [ruby-dev:44984][Bug #5753]
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0