Project

General

Profile

Backport #5646

Backport r33775

Added by tenderlovemaking (Aaron Patterson) almost 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:41114]

Description

r33775 fixes the bug reported in [ruby-core:41088] and should be backported.


Files

noname (500 Bytes) noname Anonymous, 12/01/2011 10:23 AM

History

Updated by kosaki (Motohiro KOSAKI) almost 8 years ago

Reviewed and it looks good to me.

Updated by nobu (Nobuyoshi Nakada) almost 8 years ago

It seems harmless, and I agree that it should be backported.

Updated by tenderlovemaking (Aaron Patterson) over 7 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Sorry for the delay. I backported this commit, can someone please check to make sure I didn't make a mistake?

Also, is there a script for doing backports? It looks like the commit messages are generated.

Updated by kosaki (Motohiro KOSAKI) over 7 years ago

Also, is there a script for doing backports?  It looks like the commit messages are generated.

I like tool/merger.rb. :)

Updated by Anonymous over 7 years ago

On Thu, Dec 01, 2011 at 02:19:31AM +0900, KOSAKI Motohiro wrote:

Also, is there a script for doing backports?  It looks like the commit messages are generated.

I like tool/merger.rb. :)

Thanks! We should add this to the wiki. I also heard there is a script
for generating commit messages. Is that true?

Thanks!

--
Aaron Patterson
http://tenderlovemaking.com/

Updated by kosaki (Motohiro KOSAKI) over 7 years ago

Also, is there a script for doing backports?  It looks like the commit messages are generated.

I like tool/merger.rb. :)

Thanks! We should add this to the wiki.

thank you for writing it.

I also heard there is a script
for generating commit messages.  Is that true?

true!

Updated by luislavena (Luis Lavena) over 7 years ago

On Wed, Nov 30, 2011 at 10:27 PM, KOSAKI Motohiro
kosaki.motohiro@gmail.com wrote:

I also heard there is a script
for generating commit messages.  Is that true?

true!

Oh!, whats the name of such wonderful script? :-D

--
Luis Lavena
AREA 17
-
Perfection in design is achieved not when there is nothing more to add,
but rather when there is nothing more to take away.
Antoine de Saint-Exupéry

Updated by drbrain (Eric Hodel) over 7 years ago

On Nov 30, 2011, at 17:35, Luis Lavena luislavena@gmail.com wrote:

On Wed, Nov 30, 2011 at 10:27 PM, KOSAKI Motohiro
kosaki.motohiro@gmail.com wrote:

I also heard there is a script
for generating commit messages. Is that true?

true!

Oh!, whats the name of such wonderful script? :-D

make change

Also available in: Atom PDF