Bug #5545
closedNet::HTTP breaks with https URI objects
Description
uri = URI('https://example.com/index.html?count=10')
Net::HTTP.get(uri)
will currently fail with an obscure error due to Net::HTTP attempting to speak HTTP to an HTTPS service.
I believe this is a bug, and have patched lib/net/http.rb to use SSL when you use an https URI with the get and post_form helpers.
Files
Updated by ferlatte (Mark Ferlatte) about 13 years ago
- File http.rb.diff http.rb.diff added
Updated by ferlatte (Mark Ferlatte) about 13 years ago
Sorry, apparently failed to attach the patch to the bug. Please let me know if there's anything I should change in order for this patch to be accepted.
Updated by MartinBosslet (Martin Bosslet) about 13 years ago
- Status changed from Open to Assigned
- Assignee set to drbrain (Eric Hodel)
- Target version set to 2.0.0
Thanks, Mark, for reporting this and providing the patch.
As far as I know, Eric is working on a fix for this problem, too?
Updated by ferlatte (Mark Ferlatte) about 13 years ago
That would be awesome. I saw bugs from Eric about SSL session re-use in Net::HTTP, but didn't see anything about this particular issue.
Updated by naruse (Yui NARUSE) about 13 years ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r33849.
Mark, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
-
lib/net/http.rb (Net::HTTP.get_response): enable use_ssl
if given URI object is https.
patched by Mark Ferlatte [ruby-core:40665] [Bug #5545] -
lib/net/http.rb (Net::HTTP.post_form): ditto.