Bug #5030: [Win7/MinGW] build fail on trunk@32549

• Status: Closed
• Assignee: usa (Usaku NAKAMURA)
• Target version: 2.0.0
• ruby -v: building with ruby 1.9.4dev (2011-07-15 trunk 32545) [i386-mingw32]

[jonforums (Jon Forums)]

This commit

https://github.com/ruby/ruby/commit/f15d0deaaf1ae0b92c539bd823dd2b00afbaf502

appears to be the cause of the following build failure on Win7 32bit with tdm gcc 4.5.2 and mingw-w64 gcc 4.5.4

...
compiling ../../../../Users/Jon/Documents/RubyDev/ruby-git/win32/win32.c
../../../../Users/Jon/Documents/RubyDev/ruby-git/win32/win32.c: In function 'rb_w32_io_cancelable_p':
../../../../Users/Jon/Documents/RubyDev/ruby-git/win32/win32.c:2080:5: error: implicit declaration of function 'is_socket'
../../../../Users/Jon/Documents/RubyDev/ruby-git/win32/win32.c:2080:5: error: implicit declaration of function 'is_console'
../../../../Users/Jon/Documents/RubyDev/ruby-git/win32/win32.c: At top level:
../../../../Users/Jon/Documents/RubyDev/ruby-git/win32/win32.c:2183:1: error: static declaration of 'is_socket' follows non-static declaration
../../../../Users/Jon/Documents/RubyDev/ruby-git/win32/win32.c:2080:34: note: previous implicit declaration of 'is_socket' was here
../../../../Users/Jon/Documents/RubyDev/ruby-git/win32/win32.c:2489:1: error: static declaration of 'is_console' follows non-static declaration
../../../../Users/Jon/Documents/RubyDev/ruby-git/win32/win32.c:2080:63: note: previous implicit declaration of 'is_console' was here
make: *** [win32.o] Error 1

[kosaki (Motohiro KOSAKI)]

• Status changed from Open to Assigned
• Assignee set to usa (Usaku NAKAMURA)
• Target version set to 1.9.3

[naruse (Yui NARUSE)]

• Assignee changed from usa (Usaku NAKAMURA) to nobu (Nobuyoshi Nakada)

[naruse (Yui NARUSE)]

• Assignee changed from nobu (Nobuyoshi Nakada) to usa (Usaku NAKAMURA)

[usa (Usaku NAKAMURA)]

• Target version changed from 1.9.3 to 2.0.0

[luislavena (Luis Lavena)]

is_socket is defined only in io.c:

https://github.com/ruby/ruby/blob/trunk/io.c#L236-237

is_console is only defined in win32/win32.c, but further down in the file, and is not declared before.

[usa (Usaku NAKAMURA)]

• Status changed from Assigned to Closed

fixed at r32557, I hope.

[jonforums (Jon Forums)]

Confirmed fixed at r32557 using mingw-w64 gcc 4.5.4. Passed quick testing run via make test-all TESTS='openssl fiddle psych' && make test