Project

General

Profile

Actions

Bug #4799

closed

M17N tests are too JP specific

Added by luislavena (Luis Lavena) almost 13 years ago. Updated over 11 years ago.

Status:
Closed
Target version:
ruby -v:
ruby 1.9.3dev (2011-05-29 trunk 31779) [i386-mingw32]
Backport:
[ruby-core:36551]

Description

Hello,

While attempting to successfully run 'test-all' on Windows, I found receiving several M17N tests errors due the nature of not been running on a JP codepage or configuration:

  1. Error:
    test_filename_bytes_euc_jp(TestDir_M17N):
    Errno::EINVAL: Invalid argument - C:/Users/Luis/AppData/Local/Temp/d20110529-2972-17a0lqr/?
    C:/Users/Luis/Projects/oss/ruby/test/ruby/test_dir_m17n.rb:9:in with_tmpdir' C:/Users/Luis/Projects/oss/ruby/test/ruby/test_dir_m17n.rb:150:in test_filename_bytes_euc_jp'

  2. Error:
    test_filename_euc_jp(TestDir_M17N):
    Errno::EINVAL: Invalid argument - C:/Users/Luis/AppData/Local/Temp/d20110529-2972-9kcubp/?
    C:/Users/Luis/Projects/oss/ruby/test/ruby/test_dir_m17n.rb:9:in with_tmpdir' C:/Users/Luis/Projects/oss/ruby/test/ruby/test_dir_m17n.rb:164:in test_filename_euc_jp'

  3. Error:
    test_filename_ext_euc_jp_and_int_utf_8(TestDir_M17N):
    Errno::EINVAL: Invalid argument - C:/Users/Luis/AppData/Local/Temp/d20110529-2972-8f7ny5/?
    C:/Users/Luis/Projects/oss/ruby/test/ruby/test_dir_m17n.rb:9:in with_tmpdir' C:/Users/Luis/Projects/oss/ruby/test/ruby/test_dir_m17n.rb:202:in test_filename_ext_euc_jp_and_int_utf_8'

  4. Error:
    test_filename_extutf8(TestDir_M17N):
    Errno::EINVAL: Invalid argument - C:/Users/Luis/AppData/Local/Temp/d20110529-2972-1387zsp/?
    C:/Users/Luis/Projects/oss/ruby/test/ruby/test_dir_m17n.rb:9:in with_tmpdir' C:/Users/Luis/Projects/oss/ruby/test/ruby/test_dir_m17n.rb:19:in test_filename_extutf8'

  5. Error:
    test_filename_extutf8_inteucjp_representable(TestDir_M17N):
    Errno::EINVAL: Invalid argument - C:/Users/Luis/AppData/Local/Temp/d20110529-2972-2qfh5n/?
    C:/Users/Luis/Projects/oss/ruby/test/ruby/test_dir_m17n.rb:9:in with_tmpdir' C:/Users/Luis/Projects/oss/ruby/test/ruby/test_dir_m17n.rb:91:in test_filename_extutf8_inteucjp_representable'

  6. Error:
    test_filename_extutf8_inteucjp_unrepresentable(TestDir_M17N):
    Errno::EINVAL: Invalid argument - C:/Users/Luis/AppData/Local/Temp/d20110529-2972-ig4xfu/?
    C:/Users/Luis/Projects/oss/ruby/test/ruby/test_dir_m17n.rb:9:in with_tmpdir' C:/Users/Luis/Projects/oss/ruby/test/ruby/test_dir_m17n.rb:118:in test_filename_extutf8_inteucjp_unrepresentable'

  7. Error:
    test_filename_utf8_raw_name(TestDir_M17N):
    Errno::EINVAL: Invalid argument - C:/Users/Luis/AppData/Local/Temp/d20110529-2972-tr32kz/?
    C:/Users/Luis/Projects/oss/ruby/test/ruby/test_dir_m17n.rb:9:in with_tmpdir' C:/Users/Luis/Projects/oss/ruby/test/ruby/test_dir_m17n.rb:184:in test_filename_utf8_raw_name'

8 tests, 16 assertions, 0 failures, 7 errors, 0 skips

While the backtrace line indicates Dir.mktmpdir is the root, it works perfectly on my codepage.

Which for the record is chcp 1252, but changing it to 65001 does not affect the end results:

Thank you.

Updated by naruse (Yui NARUSE) almost 13 years ago

This shold not be a JP specific bug, Japanese Windows's codepage is 932 and it is a variant of Shift-JIS, not EUC-JP.
Those errors seem problems because of the failure of automatic conversion from codepage to filesystem encoding,
but the related code seem work.
This is my impression.

P.S. the lines which raise exceptions seem strange.

Updated by naruse (Yui NARUSE) almost 13 years ago

  • Status changed from Open to Assigned
  • Assignee set to nobu (Nobuyoshi Nakada)

Updated by naruse (Yui NARUSE) over 12 years ago

I doubt some gems/library set Encoding.default_internal and its breaks those tests.
Can you run test-all in clean environment?
configure --prefix=/somewhere may help you.

Updated by luislavena (Luis Lavena) over 11 years ago

  • Status changed from Assigned to Closed

A patch for this has been submitted in #6765

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0