Project

General

Profile

Backport #4641

Please backport r31418 to 1.9.2 stable branch

Added by tenderlovemaking (Aaron Patterson) about 8 years ago. Updated about 8 years ago.

Status:
Rejected
Priority:
Normal
[ruby-core:35985]

Description

Syck cannot load valid YAML times that Psych dumps. For example '2010-10-10 00:00:00.000000000Z' is a valid YAML time, but Syck cannot load it.

r31418 makes Psych dump time in a way that Syck can load.


Files

noname (500 Bytes) noname tenderlovemaking (Aaron Patterson), 06/03/2011 03:23 AM

History

Updated by yugui (Yuki Sonoda) about 8 years ago

  • Status changed from Open to Rejected

I don't want to change behavior unless it is a bug.

This interoperability issue is a bug of syck and I know it is hard to fix this bug in syck. So is it a time to move to psych?

Updated by tenderlovemaking (Aaron Patterson) about 8 years ago

On Tue, May 31, 2011 at 10:47:00AM +0900, Yuki Sonoda wrote:

Issue #4641 has been updated by Yuki Sonoda.

Status changed from Open to Rejected

I don't want to change behavior unless it is a bug.

This interoperability issue is a bug of syck and I know it is hard to fix this bug in syck. So is it a time to move to psych?

I think Psych will work fine as the default YAML engine in 1.9.2.
You've backported the major bugs, and I haven't received any bug reports
other than the ones I've already fixed.

r31715 makes Psych default for 1.9.3. I think it can be easily
backported to 1.9.2.

If Psych is made default, and something doesn't work, people can easily
downgrade by changing the engine.

--
Aaron Patterson
http://tenderlovemaking.com/

Also available in: Atom PDF