Project

General

Profile

Bug #4617

incorrect RbConfig::CONFIG["STRIP"] values

Added by jonforums (Jon Forums) over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
ruby 1.9.3dev (2011-04-27 trunk 31364) [i386-mingw32]
Backport:
[ruby-core:<unknown>]

Description

=begin
While adding support for the mingw-w64 toolchain to the RubyInstaller project, I discovered that configure.in doesn't correctly generate values for STRIP when name-prefixed build tools (ie - i686-w64-mingw32-ranlib, etc) are used.

I tested the attached patch in the following configurations (trunk) with these results in rbconfig.rb:

  • Arch 32-bit 2.6.38 w/gcc v4.6.0 ==> CONFIG["STRIP"] = "strip -S -x"
  • Win7 32-bit, RubyInstaller w/i686-w64-ming32-gcc v4.5.3 ==> CONFIG["STRIP"] = "i686-w64-mingw32-strip"
  • Win7 32-bit, RubyInstaller w/gcc v4.5.2 ==> CONFIG["STRIP"] = "strip"

Please review and consider for inclusion in trunk, ruby_1_9_2, and ruby_1_8_7. While I've not tested the patch on 1.8.7, the code https://github.com/ruby/ruby/blob/ruby_1_8_7/configure.in#L1370-1388 looks much the same.

Regards,
Jon
=end


Files

0001-name-prefix-strip.patch (439 Bytes) 0001-name-prefix-strip.patch jonforums (Jon Forums), 04/27/2011 04:01 AM
#1

Updated by nobu (Nobuyoshi Nakada) over 9 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

=begin
This issue was solved with changeset r31365.
Jon, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • configure.in (STRIP): use proper toolchain. based on a patch from Jon Forums at [ruby-core:35909]. fixes #4617 =end

Updated by jonforums (Jon Forums) over 9 years ago

=begin
Just tested that the changeset works perfectly in all 3 configurations originally mentioned, thank you.

Should I make a separate request to backport to both ruby_1_9_2 and ruby_1_8_7?

Jon
=end

Also available in: Atom PDF