Bug #4583: trace doesn't work for methods set up by attr_*

• Status: Rejected
• Assignee: ko1 (Koichi Sasada)
• Target version: -
• ruby -v: -

[QaDeS (Michael Klaus)]

=begin
Methods set up with (({attr_accessor})) or alike are not traceable:

class Foo
attr_writer :bar
def baz=(value)
@baz = value
end
end

set_trace_func proc{|*args| puts args.inspect}
@foo = Foo.new # will be traced
@foo.bar = 'bar' # call to bar= will not be traced
@foo.baz = 'baz' # call to baz= will be traced

Expected behavior: "c-call" and "c-return" are traced.

=end

[QaDeS (Michael Klaus)]

=begin
See also issue #4584 for Ruby 1.8.
=end

[kosaki (Motohiro KOSAKI)]

• Status changed from Open to Assigned
• Assignee set to ko1 (Koichi Sasada)

=begin
Hi Michael,

Interesting report. Assigned to ko1.
=end

[QaDeS (Michael Klaus)]

• File eval.diff eval.diff added

=begin
Thanks for the hint on reporting properly. Here's a working patch for 1.8.7
=end

[QaDeS (Michael Klaus)]

• File test_settracefunc.rb.diff test_settracefunc.rb.diff added

=begin
Added test for 1.9.2-head, but changes to vm_eval.c didn't make it work. Next suspect: vm_insnhelper.c
Actually, I have no clue what I'm doing :)
=end

[QaDeS (Michael Klaus)]

• File trace_attr_accessors.patch trace_attr_accessors.patch added

=begin
Working patch for 1.9.2-head
=end

[QaDeS (Michael Klaus)]

=begin
Actually, the binding passed to the trace_func is wrong. Should be of the object the attr_accessor is defined in.
=end

[QaDeS (Michael Klaus)]

• File test_settracefunc-1.8.7.patch test_settracefunc-1.8.7.patch added
• File test_settracefunc-1.9.2.patch test_settracefunc-1.9.2.patch added

=begin
Modified the test to show the binding problem.
=end

[ko1 (Koichi Sasada)]

• ruby -v changed from ruby 1.9.2p180 (2011-02-18 revision 30909) [x86_64-linux] to -

Hi,

(2011/04/17 11:44), [e-mail] wrote:

Methods set up with (({attr_accessor})) or alike are not traceable:

class Foo
attr_writer :bar
def baz=(value)
@baz = value
end
end

set_trace_func proc{|*args| puts args.inspect}
@foo = Foo.new # will be traced
@foo.bar = 'bar' # call to bar= will not be traced
@foo.baz = 'baz' # call to baz= will be traced

Expected behavior: "c-call" and "c-return" are traced.

This is because performance issue. I want to ignore your request.
Any real problem?

--
// SASADA Koichi at atdot dot net

[ko1 (Koichi Sasada)]

• Status changed from Assigned to Feedback

[ko1 (Koichi Sasada)]

• Status changed from Feedback to Rejected

No feedback.