Project

General

Profile

Actions
Copy link

Bug #4511

closed

Ripper#end_seen? の戻り値に関するコメント

Added by sho-h (Sho Hashimoto) over 13 years ago. Updated over 13 years ago.

Status:
Closed
Assignee:
naruse (Yui NARUSE)
Target version:
2.0.0
ruby -v:
ruby 1.9.3dev (2011-03-19 trunk 31128) [x86_64-linux]
Backport:
[ruby-dev:<unknown>]

Description

=begin
Ripper#end_seen? は true か false しか返さないと思うので、コメントが間違っている気がします。例えば、以下のような修正になるのではないではないかと思います。

    • Return if parsed source ended by +__END__+.
    • This number starts from 1.
    • Return true if parsed source ended by +__END__+.

パッチも添付しておきますので、問題ないようでしたら、取り込んでやってください。
=end

Files

parse.y.patch (411 Bytes) parse.y.patch sho-h (Sho Hashimoto), 03/19/2011 02:03 PM
Actions
Copy link
 #1 [ruby-dev:43933]

Updated by naruse (Yui NARUSE) over 13 years ago

  • Status changed from Open to Assigned
  • Assignee set to naruse (Yui NARUSE)
Actions
Copy link
 #2

Updated by naruse (Yui NARUSE) over 13 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r32239.
Sho, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

  • parse.y (rb_parser_end_seen_p): fix documentation about return
    value. patched by Sho Hashimoto. [Bug #4511]
Actions
Copy link

Also available in: Atom PDF

Like0
Like0Like0