Project

General

Profile

Actions
Copy link

Bug #4067

closed

[PATCH] Fix SystemStackError when trying to format a large block of text in REXML

Added by jeremyevans0 (Jeremy Evans) about 14 years ago. Updated over 13 years ago.

Status:
Closed
Assignee:
kou (Kouhei Sutou)
Target version:
2.0.0
ruby -v:
ruby 1.9.2p0 (2010-08-18 revision 29036) [x86_64-openbsd4.8]
Backport:
[ruby-core:33245]

Description

=begin
REXML::Formatters::Pretty#wrap used a recursive method call to format text. This patch switches it to use an iterative approach. It includes a test case exposing the error.

This issue isn't theoretical, it happens when using rcov with Sequel's test suite.

Tested on 1.9.2p0, but patch is against trunk.
=end

Files

rexml_fix.diff (1.83 KB) rexml_fix.diff Patch for REXML::Formatters::Pretty#wrap jeremyevans0 (Jeremy Evans), 11/18/2010 07:46 AM
Actions
Copy link
 #1

Updated by kou (Kouhei Sutou) about 14 years ago

  • Assignee set to kou (Kouhei Sutou)
  • Target version set to 2.0.0

=begin

=end

Actions
Copy link
 #2

Updated by kou (Kouhei Sutou) about 14 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

=begin
This issue was solved with changeset r29827.
Jeremy, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

=end

Actions
Copy link

Also available in: Atom PDF

Like0
Like0Like0