Feature #255: CGI element generation methods should convert keys/values to Strings before escaping.

• Status: Closed
• Assignee: xibbar (Takeyuki FUJIOKA)
• Target version: 1.9.1 Release Candidate

=begin
@cgi.file_field("test", 40)

=> ''

@cgi.file_field("NAME" => "test", "SIZE" => 40)

=> private method `gsub' called for 40:Fixnum

The attached patch fixes this issue for all element generation methods.
Additionally, it allows passing Symbols instead of Strings for attribute names.

@cgi.file_field("NAME" => "test", "SIZE" => 40)

=> ''

@cgi.file_field(:NAME => "test", :SIZE => 40)

=> ''

=end

[NoKarma (Arthur Schreiber)]

=begin
Just wanted to say that this report and the patch are by me.
=end

[NoKarma (Arthur Schreiber)]

• File new_cgi_elements.patch new_cgi_elements.patch added

=begin
Ok, the old patch is bugged.
Converting keys to Strings using #to_s might result in duplicated element attributes, so this change has been removed.

New patch attached.
=end

[naruse (Yui NARUSE)]

• Assignee set to xibbar (Takeyuki FUJIOKA)

=begin

=end

[yugui (Yuki Sonoda)]

• Target version set to 1.9.1 Release Candidate

=begin

=end

[xibbar (Takeyuki FUJIOKA)]

• Status changed from Open to Closed

=begin

=end