Bug #19568: Windows mingw rust, failures with test/rubygems/test_gem_ext_cargo_builder.rb

• Status: Third Party's Issue
• Assignee: hsbt (Hiroshi SHIBATA)
• Target version: -
• ruby -v: master
• Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN

[MSP-Greg (Greg L)]

The Windows ucrt & mingw builds recently started failing tests in:

test/rubygems/test_gem_ext_cargo_builder.rb TestGemExtCargoBuilder

Checking changed files from the last good build showed:
array.c
gems/bundled_gems
iseq.c
lib/irb.rb
lib/irb/cmd/nop.rb
lib/irb/completion.rb
lib/irb/ext/tracer.rb
lib/irb/extend-command.rb
lib/ruby_vm/rjit/compiler.rb
lib/ruby_vm/rjit/context.rb
lib/ruby_vm/rjit/insn_compiler.rb
lib/ruby_vm/rjit/jit_state.rb
rjit_c.c
rjit_c.h
rjit_c.rb
test/irb/test_cmd.rb
tool/leaked-globals
tool/rjit/bindgen.rb
vm_callinfo.h
yjit.c
yjit/bindgen/src/main.rs
yjit/src/codegen.rs
yjit/src/cruby_bindings.inc.rs

There have been no changes to ruby-loco during this time. ruby-loco uses rust installed by dtolnay/rust-toolchain@stable, which are the tools provided by
the Rust organization. I also tried MSYS2 rust.

I've created two files showing the errors logs:
https://github.com/MSP-Greg/ruby-loco/releases/download/error_logs/windows_ucrt_rust.txt
https://github.com/MSP-Greg/ruby-loco/releases/download/error_logs/windows_ucrt_msys2.txt

I'm not familiar with Rust, so I have no idea what the issue is. I'm guessing this might be an MSYS2 issue, but I'm not sure...

[luke-gru (Luke Gruber)]

It's my understanding that these tests should not be run, they should be skipped by the method skip_unsupported_platforms!, at least they are skipped when I run make test-all. Were they being run before?

You can check this with: $ make test-all TESTOPTS="test/rubygems/test_gem_ext_cargo_builder.rb".
I get the output:

Finished tests in 1.098123s, 4.5532 tests/s, 9.1064 assertions/s.
5 tests, 10 assertions, 0 failures, 0 errors, 10 skips

I don't know how the tests are being run in mssys2, I'm assuming it's not just make test-all but something else? If so, the logic should be changed in the method skip_unsupported_platforms!

[hsbt (Hiroshi SHIBATA)]

• Status changed from Open to Third Party's Issue
• Assignee set to hsbt (Hiroshi SHIBATA)

This issue is not only make test-all. see https://github.com/rubygems/rubygems/actions/runs/4598776839/jobs/8123289961

We should fix this on rubygems repo.

[MSP-Greg (Greg L)]

@hsbt (Hiroshi SHIBATA)

Thanks.

JFYI, the problem also exists in oxidize-rb/rb-sys's CI. It may be MSYS2, but probably a Rust issue. As mentioned above, I couldn't find a change to RubyGems between the last successful ruby-loco build and the first failing build.