Project

General

Profile

Actions

Bug #18997

closed

Don't define ruby_qsort when POSIX qsort_r is available

Added by delphij (Xin Li) about 2 years ago. Updated over 1 year ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
Not applicable
[ruby-core:109845]

Description

The current code would define ruby_qsort as a wrapper of qsort_s when it is available. When both qsort_s and POSIX (GNU) qsort_r are available, we should call qsort_r directly instead, and the qsort_s wrapper is redundant.

Proposed patch at https://github.com/ruby/ruby/pull/6332 and can be applied on Ruby 2.7 and newer Ruby versions


Related issues 1 (0 open1 closed)

Related to Ruby master - Bug #20151: Can't build Ruby 3.1 on FreeBSD 14.0ClosedActions
Actions #1

Updated by nobu (Nobuyoshi Nakada) about 2 years ago

  • Backport changed from 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN to 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED
Actions #2

Updated by Anonymous about 2 years ago

  • Status changed from Open to Closed

Applied in changeset git|7400628cb054a9a9651d69411a100fc9d518099f.


[Bug #18997] Don't define ruby_qsort when POSIX qsort_r is available

The current code would define ruby_qsort as a wrapper of qsort_s
when it is available. When both qsort_s and POSIX (GNU) qsort_r
are available, we should call qsort_r directly instead, and
the qsort_s wrapper is redundant.

Updated by nagachika (Tomoyuki Chikanaga) over 1 year ago

  • Backport changed from 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED to 2.7: REQUIRED, 3.0: REQUIRED, 3.1: DONTNEED

I don't think this is necessary to backport to stable branches.

Actions #4

Updated by nobu (Nobuyoshi Nakada) 9 months ago

  • Related to Bug #20151: Can't build Ruby 3.1 on FreeBSD 14.0 added
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0