Misc #18924: lstrlen and lstrcat still in use

• Status: Open
• Assignee: -

[[e-mail] (Alexander Riccio)]

In practice, as-used, this is probably benign, but is a Terrible Idea.

There are several places where someone's still using lstrcat and lstrlen in ruby.

lstrcat catches and suppresses access violations. I have been burned by this in the wild as a user of other software, corrupting data and causing mysterious crashes. There's no good reason to use these functions. IIRC, they may even date back to before the standard library was standard (on windows?)?

Swapping them for standard functions like strcpy is not great, but can only break code that was incorrect and memory-corrupting already.

[jeremyevans0 (Jeremy Evans)]

• Tracker changed from Bug to Misc
• Backport deleted (2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN)