Project

General

Profile

Actions

Misc #16507

open

=~ vs include? or match?

Added by MSP-Greg (Greg L) almost 5 years ago. Updated almost 2 years ago.

Status:
Open
Assignee:
-
[ruby-core:96818]

Description

While working on getting the mswin build working on Actions, I thought adding mswin? and ci? methods to Minitest::Unit::Guard in tool/lib/minitest/unit.rb would be helpful.

Currently some tests are failing that are guarded/skipped based on ENV['APPVEYOR']. For ci?, I'd combine Travis, AppVeyor, & Actions.

There are quite a few instances where =~ is used for a boolean return. Would it be considered appropriate to replace those calls with include? or match?

Actions

Also available in: Atom PDF

Like0
Like0