Bug #1616: Net::BufferedIO tries to raise Timeout::TimeoutError

• Status: Closed
• Assignee: -
• Target version: 1.9.2
• ruby -v: ruby 1.9.2dev (2009-06-12 trunk 23670) [x86_64-linux]

[manveru (Michael Fellinger)]

=begin
in lib/net/protocol.rb in the Net::BufferedIO#rbuf_fill method, in some cases Timeout::TimeoutError is raised, but this class does not exist anymore.
Timeout::TimeoutError has been deprecated? Yet it's being used and mentioned in the stdlib, but only absolutely referenced in lib/net/protocol.rb while it is being set in the main namespace.

 # Another name for Timeout::Error, defined for backwards compatibility with
 # earlier versions of timeout.rb.
 TimeoutError = Timeout::Error

Other places where it's mentioned:

lib/net/smtp.rb
373: # TimeoutError is raised.
378: # TimeoutError is raised.
458: # * TimeoutError
519: # * TimeoutError
649: # * TimeoutError
703: # * TimeoutError

lib/net/pop.rb
491: # it raises a TimeoutError exception.
496: # it raises a TimeoutError exception.

lib/net/protocol.rb
140: raise Timeout::TimeoutError
148: raise Timeout::TimeoutError

lib/net/telnet.rb
250: # TimeoutError to be raised. The default value is 10 seconds.
355: rescue TimeoutError
356: raise TimeoutError, "timed out while opening a connection to the host"
513: # before raising a TimeoutError. If set to false,
560: raise TimeoutError, "timed out while waiting for more data"

lib/net/http.rb
522: # it raises a TimeoutError exception.
527: # it raises a TimeoutError exception.

lib/timeout.rb
87:TimeoutError = Timeout::Error
93: p timeout(5, TimeoutError) {

lib/resolv.rb
162: class ResolvTimeout < TimeoutError; end

lib/webrick/httprequest.rb
356: rescue TimeoutError

test/drb/drbtest.rb
171: assert_raise(TimeoutError) do
174: assert_raise(TimeoutError) do

test/ruby/test_readpartial.rb
53: assert_raise(TimeoutError) {
67: assert_raise(TimeoutError) {
=end

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

=begin
Applied in changeset r23674.
=end