Project

General

Profile

Actions

Misc #15978

closed

Deprecate FIXNUM_MIN and FIXNUM_MAX

Added by robertomiranda (Roberto Miranda) almost 5 years ago. Updated almost 5 years ago.

Status:
Rejected
Assignee:
-
[ruby-core:93498]

Updated by shyouhei (Shyouhei Urabe) almost 5 years ago

  • Status changed from Open to Feedback

Can you tell us why? We only expose these constants into C and there are fixnums in C. Usages of them are seen in the wild, for instance https://github.com/ged/ruby-pg/blob/master/ext/pg_text_decoder.c
I fail to see any reason to deprecate.

Updated by robertomiranda (Roberto Miranda) almost 5 years ago

Yeah sure basically for consistency, now that Bignum and Fixnum classes have been deprecated in favour of Integer. I think that FIXNUM_MIN and FIXNUM_MAX should be deprecated and replaced for something that reflects that ruby has a single class for integers. I was thinking something like INTEGER_MAX and INTEGER_MIN

Updated by naruse (Yui NARUSE) almost 5 years ago

  • Status changed from Feedback to Rejected

robertomiranda (Roberto Miranda) wrote:

Yeah sure basically for consistency, now that Bignum and Fixnum classes have been deprecated in favour of Integer. I think that FIXNUM_MIN and FIXNUM_MAX should be deprecated and replaced for something that reflects that ruby has a single class for integers. I was thinking something like INTEGER_MAX and INTEGER_MIN

I doubt such consistency is worth breaking compatibility.

And though Fixnum and Bignum is vanished from Ruby world, they are still alive in C world of Ruby implementation.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0