Bug #15900: Resolv::DNS#each_name doesn't accept Resolv::IPv{4,6} against documents

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: ruby 2.7.0dev (2019-06-05 master 84c294eb0b) [x86_64-linux]
• Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN

[Tietew (Toru Iwase)]

In resolv library, document says Resolv::DNS#each_name accepts String, Resolv::IPv4 and Resolv::IPv6.
But Resolv::DNS::IPv{4,6} raises ResolvError.

require 'resolv'
dns = Resolv::DNS.new
dns.each_name(Resolv::IPv4.create('127.0.0.1')) { |name| p name }

Expected: #<Resolv::DNS::Name: localhost.>
Actual: .../resolv.rb:459:in `each_name': cannot interpret as address: 127.0.0.1 (Resolv::ResolvError)

Patch attached.
Affected versions: All versions (I confirmed 2.2.10, 2.3.8, 2.4.6, 2.5.5, 2.6.3, and master)

[jeremyevans0 (Jeremy Evans)]

Thank you for the report. I was able to confirm the issue and that your patch fixes it. I will apply your patch shortly.

• Status changed from Open to Closed

Applied in changeset git|66508992483ae5d77b56a98427c50c772341c0ac.

---

Make Resolv::DNS#each_name accept Resolv::IPv{4,6} arguments

These arguments were previously documented as supported, but not
actually supported.

Patch from Toru Iwase

Fixes [Bug #15900]

[Tietew (Toru Iwase)]

Could you please backport to 2.5 and 2.6?