Project

General

Profile

Actions

Bug #15228

closed

Fix spec/ruby/core/array/reject_spec.rb & misc

Added by MSP-Greg (Greg L) over 5 years ago. Updated over 5 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
ruby 2.6.0dev (2018-10-16 trunk 65097)
[ruby-core:89423]

Description

Running some 'log inspection' code on ruby-loco, noticed spec tests that intermittently reported no examples. Most of the files were in core/array. The actual logs showed that whatever ruby instance ran reject_spec.rb had most of its subsequent core/array files report zero examples.

Code causing the problem had an incorrect return, along with an error from 'raise raise'. I believe all CI showed an increase in the example count.

See GH PR 1985. Includes two minor changes to spec/ruby/core/array/fixtures/classes.rb.

Patch attached.


Files

ruby-core-array.patch (1.16 KB) ruby-core-array.patch MSP-Greg (Greg L), 10/16/2018 09:30 PM

Updated by marcandre (Marc-Andre Lafortune) over 5 years ago

  • Status changed from Open to Closed

Good catch, thanks! Committed as r65098.

Actions

Also available in: Atom PDF

Like0
Like0