Project

General

Profile

Actions
Copy link

Bug #14966

closed

2.5 branch - Appveyor failures - backport missed line

Added by MSP-Greg (Greg L) over 5 years ago. Updated over 5 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
Current Ruby 2.5 branch
Backport:
2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: DONE
[ruby-core:88302]

Description

A while ago, @hsbt (Hiroshi SHIBATA) committed r62990, and the following line was in test\test_tmpdir.rb:

TRAVERSAL_PATH.delete!(':') if /mswin|mingw/ =~ RUBY_PLATFORM

When it was backported to 2.5 (r62971), the line was omitted. I believe it needs to be inserted at line 61. That should allow Appveyor ruby_2_5 branch to pass...

Thanks, Greg

Files

1939.patch (719 Bytes) 1939.patch hsbt (Hiroshi SHIBATA), 08/20/2018 10:23 PM
Actions
Copy link
 #2 [ruby-core:88580]

Updated by MSP-Greg (Greg L) over 5 years ago

Please see GitHub PR 1939, which passed.

I guess a look at ruby_2_4 is next, as it's also failing...

Actions
Copy link
 #3

Updated by hsbt (Hiroshi SHIBATA) over 5 years ago

  • File 1939.patch 1939.patch added
  • Status changed from Open to Closed
  • Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN to 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: REQUIRED
Actions
Copy link
 #4 [ruby-core:88820]

Updated by nagachika (Tomoyuki Chikanaga) over 5 years ago

  • Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: REQUIRED to 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: DONE

Hello Greg,

Thank you very much for your notice.
I have applied your patch at r64621 in ruby_2_5 branch.

Actions
Copy link

Also available in: Atom PDF

Like0
Like0Like0Like0Like0