Bug #14358: URI.encode_www_form_component doesn't encode bad chars properly

• Status: Closed
• Assignee: akira (akira yamada)
• Target version: -
• ruby -v: ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-linux]
• Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN

[phluid61 (Matthew Kerwin)]

URI.encode_www_form_component "\u02DA", Encoding::WINDOWS_1252
#=> "%26730%3B"

# Expected:
#=> "%26%23730%3B"

As per http://www.w3.org/TR/2013/CR-html5-20130806/forms.html#url-encoded-form-data :

"For each character in the entry's name and value that cannot be expressed using the selected character encoding, replace the character by a string consisting of a U+0026 AMPERSAND character (&), a "#" (U+0023) character, one or more ASCII digits representing the Unicode code point of the character in base ten, and finally a ";" (U+003B) character."

[phluid61 (Matthew Kerwin)]

• ruby -v set to ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-linux]

[jeremyevans0 (Jeremy Evans)]

• File uri-encode-form-compontent.patch uri-encode-form-compontent.patch added
• Status changed from Open to Assigned
• Assignee set to akira (akira yamada)

I agree this is a bug that should be fixed, and the patch is a proper way to fix it. Attached is an updated patch that applies against the master branch, along with a test.

• Status changed from Assigned to Closed

Applied in changeset git|a2c26fe1c6d49b54494b7c6301cc4c77596eec0c.

---

Fix fallback in URI.encode_www_form_component to include #

Patch from Matthew Kerwin.

Fixes [Bug #14358]