Project

General

Profile

Bug #13880

`BigDecimal(string)` should raise on invalid values in `string`

Added by ojab (ojab ojab) almost 2 years ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]
[ruby-core:82704]

Description

Right now BigDecimal() behaviour differs from Integer() and Float():

2.4.1 :001 > require 'bigdecimal'
 => true
2.4.1 :002 > BigDecimal('1,')
 => 0.1e1
2.4.1 :003 > Integer('1,')
ArgumentError: invalid value for Integer(): "1,"
        from (irb):3:in `Integer'
        from (irb):3
        from /home/ojab/.rvm/rubies/ruby-2.4.1/bin/irb:11:in `<main>'
2.4.1 :004 > Float('1,')
ArgumentError: invalid value for Float(): "1,"
        from (irb):4:in `Float'
        from (irb):4
        from /home/ojab/.rvm/rubies/ruby-2.4.1/bin/irb:11:in `<main>'

and right now AFAIU there is no way to convert, for example, String to BigDecimal with validation.

I think that BigDecimal() should likewise raise for consistency, 'bigdecimal/util' & .to_d can be used for conversion without checks analogous to .to_f/.to_i/etc.

History

#1

Updated by ojab (ojab ojab) almost 2 years ago

  • ruby -v set to ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]
#2

Updated by ojab (ojab ojab) almost 2 years ago

  • Description updated (diff)

Updated by mrkn (Kenta Murata) over 1 year ago

  • Assignee set to mrkn (Kenta Murata)
  • Status changed from Open to Assigned
#5

Updated by mrkn (Kenta Murata) over 1 year ago

  • Target version set to 2.6
#6

Updated by naruse (Yui NARUSE) over 1 year ago

  • Target version deleted (2.6)

Updated by mrkn (Kenta Murata) 8 months ago

  • Status changed from Assigned to Closed

Fixed in r66222

Also available in: Atom PDF