Project

General

Profile

Actions

Feature #13244

closed

stdlib/Logger: add option: level

Added by eike.rb (Eike Dierks) over 7 years ago. Updated over 7 years ago.

Status:
Rejected
Assignee:
-
Target version:
-
[ruby-core:79709]

Description

I'd like to suggest
to enhance the interface of stdlib/logger

The #new method should allow for an option to set the log level:

Logger#new(logdev, level:'WARN')

As with ruby 2.4 there is no provision to set the log level from #new
But instead the level attribute needs to be set on the Logger object.

This leads to code like:

def logger
  unless @logger
    @logger ||= Logger.new(STDERR)
    logger.level = 'WARN'
  end
  return logger
end

while by it would be much more expressive to write:

def logger
  @logger ||= Logger.new(STDERR, level:'WARN')
end

I believe this would not break any previous usage of the api.


Related issues 1 (0 open1 closed)

Is duplicate of Ruby master - Feature #12224: logger: Allow specifying log level in constructorClosedsonots (Naotoshi Seo)Actions
Actions #1

Updated by nobu (Nobuyoshi Nakada) over 7 years ago

  • Is duplicate of Feature #12224: logger: Allow specifying log level in constructor added

Updated by nobu (Nobuyoshi Nakada) over 7 years ago

  • Description updated (diff)
  • Status changed from Open to Rejected

It has been added since 2.4.

Actions

Also available in: Atom PDF

Like0
Like0Like0