Project

General

Profile

Actions

Feature #12971

closed

(Refactoring) Remove `defined?` checks from observer.rb

Added by itsNikolay (Nikolay Ponomarev) over 7 years ago. Updated over 2 years ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:78259]

Description

Remove defined? checks from observer.rb

  • Contains less code
  • Easier to understand Observable logic
  • No performance downgrade

Updated by itsNikolay (Nikolay Ponomarev) over 7 years ago

can be closed also =\

Updated by nobu (Nobuyoshi Nakada) over 7 years ago

You have to define the instance method, not setting instance variables on Observable module.
For example:

  module Initializer
    def initialize(*)
      @observer_peers ||= {}
      @observer_state ||= false
      super
    end
  end

  def self.included(mod)
    mod.prepend(Initializer)
    super
  end

Updated by nobu (Nobuyoshi Nakada) over 7 years ago

  • Description updated (diff)
Actions #5

Updated by jeremyevans0 (Jeremy Evans) over 2 years ago

  • Status changed from Open to Closed
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0