Bug #1282: tk extension uses old style c function declarations generating a bunch of warnings

• Status: Closed
• Assignee: nagai (Hidetoshi Nagai)
• Target version: 1.9.2
• ruby -v: ruby 1.9.2dev (2009-03-12) [i386-mswin32_90]

[cfis (Charlie Savage)]

=begin
VC 2008 doesn't seem to like old-style C function declarations. It generates a bunch of C4113 warnings, which are fake.

I know that Ruby used to use the old-style C function declarations. Is there an automated way of reformatting tcltklib.c?

---

cl -nologo -I. -I../../.ext/include/i386-mswin32_90 -I../.././../include -I../.././../ext/tk -MDd -Zi -RTC1 -W3 -wd4996 -Od -Zm600 -DRUBY_EXTCONF_H="extconf.h" -I. -I./.. -I./../missing -DLIBRUBY_SO="ruby19.dll" -IC:\Development\msvc\include -DWITH_TCL_ENABLE_THREAD=0 -Fotcltklib.obj -c -Tc../.././../ext/tk/tcltklib.c tcltklib.c
../.././../ext/tk/tcltklib.c(1561) : warning C4244: '=' : conversion from 'time_t' to 'long', possible loss of data
../.././../ext/tk/tcltklib.c(1667) : warning C4244: '=' : conversion from 'time_t' to 'long', possible loss of data
../.././../ext/tk/tcltklib.c(1722) : warning C4113: 'VALUE (__cdecl *)()' differs in parameter lists from 'VALUE (__cdecl *)(VALUE)'
../.././../ext/tk/tcltklib.c(1826) : warning C4113: 'VALUE (__cdecl *)()' differs in parameter lists from 'VALUE (__cdecl *)(VALUE)'
../.././../ext/tk/tcltklib.c(1830) : warning C4113: 'VALUE (__cdecl *)()' differs in parameter lists from 'VALUE (__cdecl *)(VALUE)'
../.././../ext/tk/tcltklib.c(1918) : warning C4113: 'VALUE (__cdecl *)()' differs in parameter lists from 'VALUE (__cdecl *)(VALUE)'
../.././../ext/tk/tcltklib.c(2431) : warning C4113: 'VALUE (__cdecl *)()' differs in parameter lists from 'VALUE (__cdecl *)(VALUE)'
../.././../ext/tk/tcltklib.c(2637) : warning C4113: 'VALUE (__cdecl *)()' differs in parameter lists from 'VALUE (__cdecl *)(VALUE)'
../.././../ext/tk/tcltklib.c(5055) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'Tcl_ObjCmdProc (__cdecl *)'
../.././../ext/tk/tcltklib.c(5057) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'Tcl_ObjCmdProc (__cdecl *)'
../.././../ext/tk/tcltklib.c(5059) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'Tcl_ObjCmdProc (__cdecl *)'
../.././../ext/tk/tcltklib.c(5555) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'Tcl_ObjCmdProc (__cdecl *)'
../.././../ext/tk/tcltklib.c(5558) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'Tcl_ObjCmdProc (__cdecl *)'
../.././../ext/tk/tcltklib.c(5561) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'Tcl_ObjCmdProc (__cdecl *)'
../.././../ext/tk/tcltklib.c(5582) : warning C4113: 'void (__cdecl *)()' differs in parameter lists from 'Tcl_InterpDeleteProc (__cdecl *)'
../.././../ext/tk/tcltklib.c(5670) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'Tcl_ObjCmdProc (__cdecl *)'
../.././../ext/tk/tcltklib.c(5685) : warning C4113: 'void (__cdecl *)()' differs in parameter lists from 'Tcl_InterpDeleteProc (__cdecl *)'
../.././../ext/tk/tcltklib.c(5851) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'Tcl_ObjCmdProc (__cdecl *)'
../.././../ext/tk/tcltklib.c(5946) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'Tcl_ObjCmdProc (__cdecl *)'
../.././../ext/tk/tcltklib.c(5959) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'Tcl_ObjCmdProc (__cdecl *)'
../.././../ext/tk/tcltklib.c(6528) : warning C4113: 'VALUE (__cdecl *)()' differs in parameter lists from 'VALUE (__cdecl *)(VALUE)'
../.././../ext/tk/tcltklib.c(7772) : warning C4113: 'VALUE (__cdecl *)()' differs in parameter lists from 'VALUE (__cdecl *)(VALUE)'
../.././../ext/tk/tcltklib.c(10125) : warning C4113: 'void (__cdecl *)()' differs in parameter lists from 'void (__cdecl *)(VALUE)'
=end

[yugui (Yuki Sonoda)]

• Category set to ext
• Status changed from Open to Assigned
• Assignee set to nagai (Hidetoshi Nagai)
• Target version changed from 1.9.1 to 1.9.2

=begin

=end

[nagai (Hidetoshi Nagai)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

=begin
Applied in changeset r24377.
=end