Bug #1165: Range.eql? and Range.== bug with subclasses

• Status: Closed
• Assignee: yugui (Yuki Sonoda)
• Target version: 1.9.2
• ruby -v: ruby 1.9.1p0 (2009-01-30 revision 21907) [i386-darwin9.6.0]

[marcandre (Marc-Andre Lafortune)]

=begin
Contrary to the documentation (and to what I would expect):

class TrivialRangeSubclass < Range
end

TrivialRangeSubclass.new(0,1) == Range.new(0,1) # ==> false

This bug is present in the current versions of ruby 1.8.7 and 1.9.1. As a matter of curiosity, I checked both JRuby (1.1.6) and rubinius (0.10.0) and they both return true (as they should).

Although I'm not familiar with the source code, it seams like a simple change, so I've included a patch for the 1.9.1 version. I hope I did things correctly! Changelog could read like:

Mon Feb 16 14:35:35 2009 Marc-Andre Lafortune [e-mail]

* range.c (range_eql, range_eq): fixed equality to work for
  subclasses of Range.

* test/ruby/test_range.rb: add assertions for above.

Thank you!
=end

[marcandre (Marc-Andre Lafortune)]

=begin
This change was made to bring Range#== and #eql? in line with the same methods for Array, Hash, String or Time in regards to subclasses. They should follow the same pattern unless there is a crucial reason not to, and in that case it must be clearly documented.

Additionally, note that String#==, for example, has the same explicit requirement in the documentation that the compared object "is a" String for == to return true. Other instances in the documentation also concur that "is a" should be understood as "is_a?", e.g. String#=~.
=end

[yugui (Yuki Sonoda)]

• Status changed from Open to Closed
• Assignee set to yugui (Yuki Sonoda)
• Target version changed from 2.0.0 to 1.9.2

=begin

=end

[runpaint (Run Paint Run Run)]

=begin
Was this meant to be closed? It doesn't appear to have been resolved.
=end

[ujihisa (Tatsuhiro Ujihisa)]

=begin
Current documentations don't mention about a subclass of Range.
http://www.ruby-doc.org/core/classes/Range.html#M000690
http://doc.okkez.net/191/view/method/Range/i/=3d=3d

Actually the Japanese one was fixed not to mention about a subclass of Range in May. http://redmine.ruby-lang.org/issues/show/1446
=end

[marcandre (Marc-Andre Lafortune)]

=begin
Thanks Ujihisa for these links.

The fact that the doc doesn't mention the behavior for subclasses (which is true as well for String, Array, Hash, Time) doesn't change what the best behavior should be.

Could this ticket be set back to "Open", since no change appears to have taken place and no justification for the current behavior was given? Thanks
=end