Project

General

Profile

Actions
Copy link

Bug #11579

closed

Fiddle.win32_last_error after calling Fiddle::Function#call isn't GetLastError()

Bug #11579: Fiddle.win32_last_error after calling Fiddle::Function#call isn't GetLastError()

Added by cremno (cremno phobia) almost 11 years ago. Updated over 5 years ago.

Status:
Closed
Assignee:
kou (Kouhei Sutou)
Target version:
-
ruby -v:
Backport:
2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
[ruby-core:<unknown>]
Tags:
patch, ext

Description

The current source code is:

    rb_funcall(mFiddle, rb_intern("last_error="), 1, INT2NUM(errno));
#if defined(_WIN32)
    rb_funcall(mFiddle, rb_intern("win32_last_error="), 1, INT2NUM(errno));
#endif

I guess this is a copy-and-paste mistake and not the intended behavior. The attached patch is untested.

Files

fix-fiddle-win32_last_error.diff (1.42 KB) fix-fiddle-win32_last_error.diff cremno (cremno phobia), 10/10/2015 11:22 AM

Updated by cremno (cremno phobia) over 10 years ago Actions
Copy link
 #1 [ruby-core:74485]

  • Assignee set to tenderlovemaking (Aaron Patterson)

Updated by kou (Kouhei Sutou) over 5 years ago Actions
Copy link
 #2 [ruby-core:103517]

  • Status changed from Open to Closed
  • Assignee changed from tenderlovemaking (Aaron Patterson) to kou (Kouhei Sutou)
Actions
Copy link

Also available in: PDF Atom