Feature #10261: [PATCH] Fix improper test method

• Status: Closed
• Assignee: -
• Target version: 2.2.0

[gogotanaka (Kazuki Tanaka)]

Right now, a test method TestMath#assert_infinity implement like below,

def assert_infinity(a, *rest)
  rest = ["not infinity: #{a.inspect}"] if rest.empty?
  assert_not_predicate(a, :finite?, *rest)
end

I suppose this is intended to check Float::INFINITY or not,

but Float#finite returns True if the value is not NaN or ±Float::INFINITY.

So I fixed it to check Float::INFINITY or not.

If you have different aim for that, please feel free to tell me.

Thank you. gogo.

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

Applied in changeset r47635.

---

test_math.rb: use Float#infinite?

• test/ruby/test_math.rb (TestMath#assert_infinity): Float#finite?
  returns true also for NaN, so use Float#infinite? instead.
  [ruby-core:65117] [Feature #10261]