Project

General

Profile

Actions
Copy link

Misc #10249

closed

[PATCH] set rb_event_flag_t to uint32_t

Added by normalperson (Eric Wong) about 10 years ago. Updated almost 10 years ago.

Status:
Closed
Assignee:
ko1 (Koichi Sasada)
[ruby-core:65083]

Description

This ensures a consistent implementation between 32 and 64-bit
platforms, as vm_trace.c limits events to 32-bits.

This is an ABI change late in the 2.2.0 development,
I'm OK if we wait until 2.3.0 for this...

Files

0001-ruby.h-set-rb_event_flag_t-to-uint32_t.patch (929 Bytes) 0001-ruby.h-set-rb_event_flag_t-to-uint32_t.patch normalperson (Eric Wong), 09/17/2014 07:19 AM
Actions
Copy link
 #1 [ruby-core:65315]

Updated by ko1 (Koichi Sasada) about 10 years ago

I'm not sure why it is valuable, but no problem to do it.

Actions
Copy link
 #2 [ruby-core:65349]

Updated by normalperson (Eric Wong) about 10 years ago

wrote:

I'm not sure why it is valuable, but no problem to do it.

Committed r47759 - This can open up some tiny data structure packing
opportunities. I prefer small data structures in general, as Ruby keeps
getting bigger :<

Actions
Copy link
 #3 [ruby-core:66521]

Updated by ko1 (Koichi Sasada) almost 10 years ago

  • Status changed from Open to Closed
Actions
Copy link

Also available in: Atom PDF

Like0
Like0Like0Like0