General

Profile

lengarvey (Leonard Garvey)

Issues

open closed Total
Assigned issues 0 0 0
Reported issues 0 2 2

Activity

07/01/2014

01:28 PM Ruby Bug #9986: WEBrick content-length being set when transfer-encoding is chunked
I've split out my patch into two separate patches. The first contains a failing test and the second contains a fix which has been applied to `WEBrick::HTTPResponse#[]=` instead of `#chunked?`
I assume this is the correct way of supply...
lengarvey (Leonard Garvey)
01:10 PM Ruby Feature #2542: URI lib should be updated to RFC 3986
I've implemented something similar to that policy in the following gist: https://gist.github.com/lengarvey/31983eac6664351ed16d
It's a very basic naive implementation but I believe it roughly does what we need URI.parse to do.
lengarvey (Leonard Garvey)
06:36 AM Ruby Bug #9990: URI.parse and URI.encode use different RFCs
I did see it, this bug points out that URI.escape isn't covered by that change. I'm not sure if there's a more appropriate place for that feedback besides raising this issue though. This is a separate issue to the one raised by @tenderlo... lengarvey (Leonard Garvey)

06/30/2014

08:14 AM Ruby Bug #9986: WEBrick content-length being set when transfer-encoding is chunked
Thanks for taking another look.
It's a relatively simple fix either way, I made the change in HTTPResponse#chunked? because I assumed that less 3rd parties would use this method so would be less affected by the additional logic withi...
lengarvey (Leonard Garvey)

06/28/2014

09:10 AM Ruby Bug #9990 (Closed): URI.parse and URI.encode use different RFCs
The latest code for URI.parse uses RFC3986 but URI.encode/URI.escape still uses the old URI::RFC2396_Parser implementation of encode. This causes problems when the specs diverge.
In RFC3986 square brackets "[" and "]" are reserved and...
lengarvey (Leonard Garvey)
01:55 AM Ruby Bug #9986: WEBrick content-length being set when transfer-encoding is chunked
I don't believe this is a duplicate of #9927. This occurs if you're not issuing a HEAD request and affects Safari with standard rack applications which use the Rack::Chunked middleware.
~~~
ᐅ curl -i http://localhost:8000
HTTP/1.1 2...
lengarvey (Leonard Garvey)

06/27/2014

04:32 PM Ruby Bug #9986 (Closed): WEBrick content-length being set when transfer-encoding is chunked
It's possible to get WEBrick to return both Transfer-Encoding: chunked and a calculated Content-length header. If the Transfer-encoding header is set via WEBrick::HTTPResponse#[]= then #chunked? will return false and the content length w... lengarvey (Leonard Garvey)

Also available in: Atom