General

Profile

sam.saffron (Sam Saffron)

Issues

Activity

11/29/2019

01:46 AM Ruby master Feature #16345: Don't emit deprecation warnings by default.
Matz,
We already have `RUBYOPT=-W0` so no change is needed here for a global suppression. Maybe add `RUBYOPT=--no...
sam.saffron (Sam Saffron)

11/27/2019

11:13 PM Ruby master Feature #16345: Don't emit deprecation warnings by default.
I tried Jeremy's patch results are here of running Discourse `bin/turbo_rspec` it runs our test suite using 16 thread... sam.saffron (Sam Saffron)
07:20 AM Ruby master Feature #16345: Don't emit deprecation warnings by default.
I agree 100% with akr here.
Even with @Eregon's proposed patch running our test suite with warnings is unusable ca...
sam.saffron (Sam Saffron)

11/16/2019

10:58 PM Ruby master Feature #16345: Don't emit deprecation warnings by default.
> It's actually a lot faster
A lot faster than no warning at all? Was just concerned looking up the callsite and ...
sam.saffron (Sam Saffron)
12:46 AM Ruby master Feature #16345: Don't emit deprecation warnings by default.
> any chance you could try https://github.com/ruby/ruby/pull/2458 and let us know how many warnings are reported for... sam.saffron (Sam Saffron)

11/13/2019

09:02 PM Ruby master Feature #16345: Don't emit deprecation warnings by default.
> I'm against not emitting deprecation warnings by default.
I disagree with this, in this case the enormous amoun...
sam.saffron (Sam Saffron)
04:53 AM Ruby master Feature #16345: Don't emit deprecation warnings by default.
I also support this, seems like a much better default. In fact when 3.0 upgrade becomes a must cause 2.7 is going EOL... sam.saffron (Sam Saffron)

11/11/2019

01:00 AM Ruby master Feature #16289: Reduce duplicated warnings for the change of Ruby 3 keyword arguments
Note... some of this fiddling with keyword arguments is showing up as a slowdown in rubybench
https://rubybench.or...
sam.saffron (Sam Saffron)

11/10/2019

10:20 PM Ruby master Feature #16289: Reduce duplicated warnings for the change of Ruby 3 keyword arguments
Just to provide some context on the extent of the issue.
Running the spec suite for Discourse results in 2,698,774...
sam.saffron (Sam Saffron)

11/08/2019

07:01 AM Ruby master Feature #14183: "Real" keyword argument
Matz said:
> If we made the decision, we will make it warn you first for a year or two before the actual change.
...
sam.saffron (Sam Saffron)

Also available in: Atom