> The original patch has a merge conflict. However, I have opened a pull request with the fix for this issue (https://github.com/ruby/ruby/pull/2713) that has been rebased to resolve the merge conflict. The github PR has been merged, ...dylants (Dylan Thacker-Smith)
Both of those instructions serve a purpose, but they could also be optimized away. `next_catch_label` is referenced from the catch table. That catch table may be optimized away, which is why you are seeing the label being omitted from...dylants (Dylan Thacker-Smith)
> I need to remember why such special (additional) calculation is done I'm not sure what you mean by additional calculation. It is decrementing `start` when non-zero as expected to loop over that number of frames, it just was missing...dylants (Dylan Thacker-Smith)
> Maybe String#capacity and String#capacity= would make sense? Using `capacity=` for the method name would set the assumption that the capacity is exactly that after the call. However, with embedded strings, the capacity would be fix...dylants (Dylan Thacker-Smith)
If we want `clear` to shrink memory by default, a `shrink: true` keyword argument could be added so the user could override this default with `clear(shrink: false)`. This would make the change less risky, since it wouldn't change the be...dylants (Dylan Thacker-Smith)
What makes sense probably depends on how long lived the String is and whether there is an upper-bound to how much needs to be stored in it. For instance, there may be a rare iteration of a loop that adds a lot to the String, which mig...dylants (Dylan Thacker-Smith)
I agree that `source_location` would be better for this new feature, since it is referring to the receiver of the call. `const_source_location` makes sense for the existing method, since it is referring to the source location of somethi...dylants (Dylan Thacker-Smith)
The original patch has a merge conflict. However, I have opened a pull request with the fix for this issue (https://github.com/ruby/ruby/pull/2713) that has been rebased to resolve the merge conflict.dylants (Dylan Thacker-Smith)
It looks like we can now use the `resolv_timeout` `Socket.tcp` option that was recently added by https://bugs.ruby-lang.org/projects/ruby-trunk/repository/git/revisions/0e9d56f5e73ed2fd8e7c858fdea7b7d5b905bb64. The only complication w...dylants (Dylan Thacker-Smith)
https://bugs.ruby-lang.org/issues/16123 added support for making private methods calls explicitly through `self`, so in class `A` `self.b` could be used to call a private class method `b`. If consistency with private methods is desired,...dylants (Dylan Thacker-Smith)