General

Profile

kbrock (Keenan Brock)

  • Login: kbrock
  • Registered on: 05/05/2017
  • Last sign in: 09/12/2024

Issues

open closed Total
Assigned issues 0 0 0
Reported issues 0 2 2

Activity

12/05/2025

07:50 PM Ruby Feature #20750 (Closed): Allow rb_thread_call_with_gvl to work when thread already has GVL
Applied in changeset commit:git|2b057859414d1ccfa4d88a898d27defc8c74dc1c.
----------
Allow rb_thread_call_with_gvl() to work when thread already has GVL
[Feature #20750]
Co-authored-by: Benoit Daloze <eregontp@gmail.com>
kbrock (Keenan Brock)
07:50 PM Ruby Revision 2b057859 (git): Allow rb_thread_call_with_gvl() to work when thread already has GVL
[Feature #20750]
Co-authored-by: Benoit Daloze <eregontp@gmail.com>
kbrock (Keenan Brock)

09/19/2024

09:50 PM Ruby Feature #20756 (Rejected): Introduce Boolean class
Hello All,
Is is possible to add a parent class for `TrueClass` and `FalseClass`?
I always found it strange that there was not a concept to group `true` and `false` together.
e.g.:
```ruby
class TrueClass < Boolean ; end
cla...
kbrock (Keenan Brock)
04:39 PM Ruby Feature #20750: Allow rb_thread_call_with_gvl to work when thread already has GVL
Hello,
Here is the new proposed patch for your review.
https://github.com/ruby/ruby/pull/11649
I do not know if we try and keep changes as small as possible (to avoid introducing bugs)
Or if we refactor along the way.
kbrock (Keenan Brock)
03:55 PM Ruby Feature #20750: Allow rb_thread_call_with_gvl to work when thread already has GVL
Benoit,
Thank you.
Maybe I should have run the more complete pattern that I see in the ruby code base:
```c
if(!ruby_native_thread_p()) { // (th = ruby_thread_from_native()) == 0
//issues
else if(ruby_threa...
kbrock (Keenan Brock)

09/17/2024

10:34 PM Ruby Feature #20750: Allow rb_thread_call_with_gvl to work when thread already has GVL
Hello Benoit,
Thank you for your question.
Eregon (Benoit Daloze) wrote in #note-1:
> This seems like a strange pattern, why not just use `rb_thread_call_with_gvl` and remove the condition?
> ...
Yes, agreed. The pattern seems ov...
kbrock (Keenan Brock)
04:52 PM Ruby Feature #20750 (Closed): Allow rb_thread_call_with_gvl to work when thread already has GVL
Hello All,
I'm hoping we can make `ruby_thread_has_gvl_p` a public method and no longer experimental.
I saw the following code in a gem that was not compiling with ruby 3.3:
``` c
// int ruby_thread_has_gvl_p(void); // <== line...
kbrock (Keenan Brock)

Also available in: Atom