Remove the quick stop path after convert_unit_to_func
Now I'm not exactly sure why I needed to check stop_worker_p after mjit_copy_cache_from_main_thread of convert_unit_to_func
in 4161674b2fbea6bdd01783ac5d3b39d88db22972.
If it's for avoiding deadlock under in_gc condition, we should keep it.
However, if it's not the case and it's just for retrying accidental
compilation failure or just to avoid MJIT_ATOMIC_SET and compact_all_jit_code, I think this quick stop path is not mandatory.
Because this path is somewhat problematic in my upcoming fix in
mjit_worker, let me try to remove this first and see how CI goes.
Added by k0kubun (Takashi Kokubun) over 4 years ago
Remove the quick stop path after convert_unit_to_func
Now I'm not exactly sure why I needed to check
stop_worker_paftermjit_copy_cache_from_main_threadofconvert_unit_to_funcin 4161674b2fbea6bdd01783ac5d3b39d88db22972.
If it's for avoiding deadlock under
in_gccondition, we should keep it.However, if it's not the case and it's just for retrying accidental
compilation failure or just to avoid
MJIT_ATOMIC_SETandcompact_all_jit_code, I think this quick stop path is not mandatory.Because this path is somewhat problematic in my upcoming fix in
mjit_worker, let me try to remove this first and see how CI goes.